Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Travel 3.0 #2703

Merged
merged 31 commits into from
Jul 27, 2017
Merged

Time Travel 3.0 #2703

merged 31 commits into from
Jul 27, 2017

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Jul 11, 2017

Resolves #2686 and moves towards #2677.

Notes

  • Zooming discoverability might be an issue, but we won't know that for sure until we get some tracking data. The only way now to control the zooming is via scrolling (as the tooltip suggests), so we have to test if it works on touchpads.
  • There are no mockups for the timestamps that I implemented here - they are a result of brainstorming between @bia and me:
    image_uploaded_from_ios_1024

@fbarl fbarl self-assigned this Jul 11, 2017
@fbarl fbarl force-pushed the time-travel-timeline-redesign branch 4 times, most recently from 3cfe6df to fd611ab Compare July 25, 2017 11:24
@fbarl fbarl changed the title [WIP] Time Travel 3.0 Time Travel 3.0 Jul 25, 2017
@fbarl fbarl requested a review from foot July 25, 2017 12:13
@foot
Copy link
Contributor

foot commented Jul 25, 2017

Looks and feels really great! Nice one 👍 👍

  • browser window moves a bit onScroll under osx (maybe needs prevDefault?)
  • "go back a bit further" controls are the edge are nice, no "go forward" a bit equiv?
  • clicking on a visible label on the timeline feels a tiny bit disorienting: where did it go? what state am in now. Feels like a place where a little animation might actually help.
  • I like being able to toggle by clicking time travel a lot!
  • small glitch? timetravel > live > (while its still going into "live") quickly click pause.
    • stuck in limbo. can recover okay though.

@fbarl
Copy link
Contributor Author

fbarl commented Jul 25, 2017

@foot

  • browser window moves a bit onScroll under osx (maybe needs prevDefault?)

Could you try fixing that on your laptop? I can't really test it without getting live feedback.

  • "go back a bit further" controls are the edge are nice, no "go forward" a bit equiv?

The idea of these markers on the left side was to signal the overall context in the timeline and the fact that they are clickable is just a nice bonus. I was thinking of also adding them to the right side, but then I thought it would make it more cluttered and the context wouldn't be that obvious from a glance. I'm still not sure about it, but for the start I'd just leave it as it is.

  • clicking on a visible label on the timeline feels a tiny bit disorienting: where did it go? what state am in now. Feels like a place where a little animation might actually help.

I added the animation and it looks much better now!

  • I like being able to toggle by clicking time travel a lot!

Me too :)

  • small glitch? timetravel > live > (while its still going into "live") quickly click pause.
    stuck in limbo. can recover okay though.

I fixed it, i.e. made it consistent with what happens when you click on LIVE -> TIME TRAVEL. Not sure that fixes all the glitches, but it does seem to behave better.

@fbarl fbarl force-pushed the time-travel-timeline-redesign branch from 77c89c2 to 4b19216 Compare July 27, 2017 12:06
@fbarl fbarl merged commit 2183a93 into master Jul 27, 2017
@fbarl fbarl deleted the time-travel-timeline-redesign branch August 8, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants